Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI,
urllib3 >= 2.0 doesn't define urllib3.util.ssl_.DEFAULT_CIPHERS anymore and this creates an import error in the current gpsoauth code.
This change checks the version and removes the import when not needed
The removal is documented here: https://urllib3.readthedocs.io/en/stable/changelog.html#removed
"Removed DEFAULT_CIPHERS, HAS_SNI, USE_DEFAULT_SSLCONTEXT_CIPHERS, from the private module urllib3.util.ssl_ (#2168)."
I ran the pre-commit before submiting. One warning related to the google import was still there but I didn't fix it as it wasn't related to teh same issue.
Best,