perf: improve the memory usage of histogram #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we do this for the other metric types as well? |
I checked only |
xsbchen
force-pushed
the
histogram-memory-improve
branch
from
aa76235
to
5b58cd4
Compare
|
@voltbit thoughts on this? Seems reasonable to me, but I have to admit I'm a bit unsure how this code works 😅 |
SimenB
approved these changes
Jan 12, 2024
|
Looks good to me. The data struct being there when exemplars are disabled was an overlook on my side I think. |
|
@zbjornson @siimon master, plz help to review it if you are free, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where it generates a huge amount of histograms, each has more than 10 labels, we found the memory usage is quite high, under this scenario, we did an experiment and found that removing bucketExemplars field from histograms could save about
27%memory usage for each histogram instance, hope the maintainers could review and consider it