feat: startTimer with exemplar #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pigrabbit
changed the title
Histogram.startTimer fails when exemplars enabled.
zbjornson
force-pushed
the
feature/start-timer-with-exemplar
branch
from
7716995
to
24f7303
Compare
zbjornson
approved these changes
Nov 25, 2023
|
Heh, there it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Histogram.startTimer()with 'enableExemplars' option set to true in order to record duration, it throws an error as following.It supposed to work normally as it does when 'enableExemplars' option set to false.
Plus, it would be better if we could provide adding exemplarLabels just like we could do with
Histogram.observe().I have added the feature with regarding test cases. Please feel free to give me any feedback.