Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds TSA URI for customMetadata. #1646

Merged
merged 2 commits into from Feb 27, 2024

Conversation

ianhundere
Copy link
Contributor

@ianhundere ianhundere commented Feb 27, 2024

closes #1645 #1645

Summary

Adds TSA to TUF custom metadata.

Currently, when verifying a TSA timestamp w/ cosign you get the following:

**Warning** Custom metadata not configured properly for target tsa_leaf.crt.pem, skipping target
**Warning** Custom metadata not configured properly for target tsa_root.crt.pem, skipping target

This is due to a missing URI in TUF's customMetadata (e.g. scaffolding) which will eventually be change to a "trusted root" file.

Further info about this specific issue.

as well as @haydentherapper's recent post on how TUF + Scaffolding's metadata will be evolving (e.g. "trusted root" file).

Release Note

Documentation

Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
@ianhundere ianhundere changed the title fix: adds TUF URI for customMetadata. fix: adds TSA URI for customMetadata. Feb 27, 2024
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@haydentherapper haydentherapper merged commit 2cbe097 into sigstore:main Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds missing URI to TUF customMetadata
2 participants