Convert ED25519phSignerVerifier to the Pure version #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See sigstore/cosign@16c0256 for how this is going to be used in Cosign. |
Signed-off-by: Riccardo Schirone <riccardo.schirone@trailofbits.com>
ret2libc
force-pushed
the
convert-ed25519ph-pure
branch
from
33307d2
to
59c5484
Compare
haydentherapper
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In sigstore/fulcio#1388 (comment) we agreed to just use ED25519 (Pure) in Fulcio. That means that in Cosign (maybe elsewhere?) we need to convert a ED25519phSignerVerifier to the Pure version, but for doing so we need access to the Private key, thus the new
ConvertToED25519API.Release Note
ConvertToED25519method toED25519phSignerVerifierto convert theED2551phSignerVerifier to aED25519one.Documentation