-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hash algorithm method to the KMS clients #1426
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just a question about the interface change
Signed-off-by: Meredith Lancaster <malancas@github.com>
The failure might be due to a aws mock that needs to be updated since there are different calls being made, though i haven't looked closely. |
Agreed, I'm going to take closer look at the aws mock. |
Summary
Opened as part of a discussion on sigstore/timestamp-authority#488, this adds a
HashFunc
method (open to any name suggestions) to the KMS clients. This method will return the hash algorithm used with the signing key. I opened this so we could use the signing key has function in sigstore/timestamp-authority without having to pass the hash function as a flag to the server. See this PR for how the new KMS method is used in the TSA.Release Note
Documentation