Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Steve Garf <garf@chainguard.dev>
  • Loading branch information
stgarf committed Feb 14, 2024
1 parent 16e4221 commit 7191539
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/oauth/interactive.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ func GetInteractiveSuccessHTML(autoclose bool, timeout int) (string, error) {
}

const (
// DefaultInteractiveSuccessHTML is the page displayed upon success when using a web browser during an interactive Oauth token flow.
DefaultInteractiveSuccessHTML = `<!DOCTYPE html>
// InteractiveSuccessHTML (deprecated) is the page displayed upon success when using a web browser during an interactive Oauth token flow.
InteractiveSuccessHTML = `<!DOCTYPE html>
<html>
<head>
<title>Sigstore Authentication</title>
Expand Down
2 changes: 1 addition & 1 deletion pkg/oauthflow/flow.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func ConnectorIDOpt(prov string) oauth2.AuthCodeOption {
// DefaultIDTokenGetter is the default implementation.
// The HTML page and message printed to the terminal can be customized.
var DefaultIDTokenGetter = &InteractiveIDTokenGetter{
HTMLPage: soauth.DefaultInteractiveSuccessHTML,
HTMLPage: soauth.InteractiveSuccessHTML,
}

// PublicInstanceGithubIDTokenGetter is a `oauth2.sigstore.dev` flow selecting github as an Idp
Expand Down

0 comments on commit 7191539

Please sign in to comment.