Update sigstore_rekor.proto #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
requested review from
haydentherapper,
woodruffw and
kommendorkapten
woodruffw
previously approved these changes
Mar 6, 2024
|
LGTM -- might need to re-generate to propagate the comment to each codebase 🙂 |
Remove timestamp from checkpoint docs. Co-authored-by: Hayden B <hblauzvern@google.com> Signed-off-by: Appu <appu@google.com>
loosebazooka
force-pushed
the
loosebazooka-patch-1
branch
from
c9704cc
to
3cbd624
Compare
haydentherapper
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove timestamp from checkpoint docs.
A followup from our meeting. Timestamp is no longer included in the checkpoint. The spec says other optional data can follow but the top 3 values must be included.