Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose service order #1537

Merged
merged 1 commit into from Jan 26, 2024
Merged

Commits on Jan 25, 2024

  1. Fix docker-compose service order

    Without this change, when Fulcio is run in docker-compose, signing an
    artifact may fail with the error "Error entering certificate in CTL".
    This happens if the docker-compose service have been run previously on
    the host and the ctfeConfig volume is populated from the last run, so
    it would generally only be seen in a developer environment. The error
    happens because the ctfe_init container starts too soon, and ct_server
    starts with Fulcio's ephemeral root CA from the last run, which is now
    the wrong CA. This change fixes the issue by ensuring ct_server only
    starts after ctfe_init has exited successfully, instead of just after it
    is started. This also means that Fulcio needs to be one of the first
    services to start so that it can make the ephemeral CA available to
    download.
    
    Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    cmurphy committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    bcbf96a View commit details
    Browse the repository at this point in the history