-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: user telemetry support updates #1978
Conversation
…onType` enums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR introduces telemetry support features and improves code organization across common modules, with focus on telemetry sink configurations and user account management.
- Added new
TelemetrySinkConfig
enum in/common/src/models/telemetry.rs
with implementations for Betterstack, Datadog, and GrafanaCloud integrations - Enhanced
/common/src/models/user.rs
withIntoStaticStr
trait forAccountTier
andSubscriptionType
enums - Introduced
integration-tests
feature flag in/common/Cargo.toml
for conditional compilation of test-specific code
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
No significant changes found since the last review. The only modification is a minor typo fix in common/Cargo.toml
where 'utilty' was corrected to 'utility' in a comment. The core functionality and structure remain unchanged from the previous review.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Description of change
PR adds a few minor changes in support of the upcoming user telemetry feature release