Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v0.51.0 #1954

Merged
merged 4 commits into from
Jan 10, 2025
Merged

chore: v0.51.0 #1954

merged 4 commits into from
Jan 10, 2025

Conversation

jonaro00
Copy link
Member

No description provided.

@jonaro00 jonaro00 merged commit c6e1368 into shuttle-hq:main Jan 10, 2025
25 checks passed
@jonaro00 jonaro00 deleted the v0.51.0 branch January 10, 2025 10:07
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements a coordinated version bump from 0.50.0 to 0.51.0 across the entire Shuttle platform.

  • Adds new features including SerdeJsonOperator for JSON storage, Axum 0.8 support (dropping 0.6), and OpenDAL on postgres output type
  • Updates examples submodule reference from 917a24e to 6fece5f to maintain compatibility with the new version
  • Replaces hardcoded version numbers with '...' in documentation to prevent outdated references

43 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -7,5 +7,5 @@ edition = "2021"
[workspace]

[dependencies]
shuttle-runtime = "0.50.0"
shuttle-runtime = "0.51.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: tokio 1.22 is quite old (current is 1.36). Consider updating tokio along with this version bump to get security fixes and performance improvements

@@ -7,5 +7,5 @@ edition = "2021"
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: empty workspace section could be removed since it serves no purpose

@@ -7,5 +7,5 @@ edition = "2021"
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Empty [workspace] section could be removed if not needed for test package

@@ -7,5 +7,5 @@ edition = "2021"
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: empty workspace section could be removed since it's not being used

@@ -13,7 +13,7 @@ diesel-async = { version = "0.4.1", optional = true }
paste = "1.0.7"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
shuttle-service = { path = "../../service", version = "0.50.0" }
shuttle-service = { path = "../../service", version = "0.51.0" }
sqlx = { version = "0.8.2", optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: sqlx 0.8.2 is not the latest in the 0.8.x series, consider updating for security fixes

@@ -11,5 +11,5 @@ keywords = ["shuttle-service", "persistence"]
async-trait = "0.1.56"
bincode = "1.2.1"
serde = { version = "1", features = ["derive"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: serde dependency uses a bare '1' version specifier - consider constraining to a more specific version range for better dependency predictability

@@ -11,5 +11,5 @@ keywords = ["shuttle-service", "persistence"]
async-trait = "0.1.56"
bincode = "1.2.1"
serde = { version = "1", features = ["derive"] }
shuttle-service = { path = "../../service", version = "0.50.0" }
shuttle-service = { path = "../../service", version = "0.51.0" }
thiserror = "2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: thiserror dependency uses a bare '2' version specifier - consider constraining to a more specific version range for better dependency predictability

@@ -11,7 +11,7 @@ keywords = ["shuttle-service", "opendal"]
async-trait = "0.1.56"
opendal = "0.51"
serde = { version = "1", features = ["derive"] }
shuttle-service = { path = "../../service", version = "0.50.0" }
shuttle-service = { path = "../../service", version = "0.51.0" }

[dev-dependencies]
tokio = { version = "1.28.2", features = ["rt-multi-thread", "macros"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: consider updating tokio to a more recent version than 1.28.2 for security and performance improvements

Comment on lines 13 to 14
serde = { version = "1", features = ["derive"] }
serde_json = "1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: serde and serde_json versions use unbound version constraints (1). Consider using more specific version bounds to prevent unexpected breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant