Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-db): SerdeJsonOperator for json storage #1952

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Jan 9, 2025

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Introduces a new SerdeJsonOperator wrapper for PostgreSQL that adds JSON serialization/deserialization capabilities to OpenDAL storage operations.

  • Added SerdeJsonOperator struct in /resources/shared-db/src/postgres.rs with methods read_serialized and write_serialized for JSON operations
  • Implemented proper error handling by wrapping serde_json errors into opendal::Error types
  • Added conditional export of SerdeJsonOperator in /resources/shared-db/src/lib.rs under the 'opendal-postgres' feature flag

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

Added Clone and Debug trait implementations to SerdeJsonOperator for improved developer experience and debugging capabilities.

  • Added #[derive(Clone, Debug)] to SerdeJsonOperator struct in /resources/shared-db/src/postgres.rs
  • Ensured proper trait bounds for the generic type parameter in SerdeJsonOperator's Clone implementation
  • Improved error messages in JSON serialization/deserialization operations

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 merged commit f0a0735 into shuttle-hq:main Jan 9, 2025
25 checks passed
@jonaro00 jonaro00 deleted the serdejsonoperator branch January 9, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants