Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shuttle-axum): support axum 0.8, drop axum 0.6 #1951

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Jan 9, 2025

feature flag for using 0.7

tested by compiling axum/hello-world with both 0.7 and 0.8

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds support for Axum 0.8 while maintaining compatibility with versions 0.7 and 0.6 in the shuttle-axum service integration.

  • Updated axum dependency in services/shuttle-axum/Cargo.toml to support versions >=0.7.3, <0.9.0
  • Modified services/shuttle-axum/README.md to use version placeholders instead of hardcoded version numbers
  • Simplified tracing functionality in runtime/src/start.rs by using fully qualified paths for logging statements

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR updates the Axum integration to make version 0.8 the default while providing backward compatibility for 0.7 through feature flags.

  • Removed support for Axum 0.6 and updated binding logic in services/shuttle-axum/src/lib.rs to use the new serve function pattern
  • Added axum-0-7 feature flag in services/shuttle-axum/Cargo.toml for optional 0.7.3 compatibility
  • Updated services/shuttle-axum/README.md to clarify that 0.8 is now the default version with instructions for using 0.7

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 changed the title feat(shuttle-axum): support axum 0.8 feat(shuttle-axum): support axum 0.8, drop axum 0.6 Jan 9, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

Updated CI configuration to align with the new Axum version support structure, ensuring proper testing of both 0.8 and 0.7 versions.

  • Modified feature flag testing in Makefile.toml to replace axum-0-6 with axum-0-7 in CI tasks
  • Updated services/shuttle-axum/Cargo.toml to set Axum 0.8.1 as the default version
  • Added explicit version numbers in services/shuttle-axum/README.md for clarity in feature flag usage

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated examples submodule to align with the new Axum version support structure.

  • Updated examples submodule reference from 7a65de0 to 917a24e to reflect Axum 0.8 compatibility
  • Removed axum-0-6 feature flag testing in Makefile.toml but should add explicit testing for Axum 0.8
  • Consider adding test coverage for both 0.7 and 0.8 versions in CI pipeline

6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR updates the axum dependency to version 0.8.1 across multiple test resources while maintaining compatibility with version 0.7 through feature flags.

  • Updated axum dependency to 0.8.1 in test resources service/tests/resources/*/Cargo.toml
  • Potential compatibility issue with tokio 1.22.0 in workspace test resources which may be too old for axum 0.8.1
  • Consider updating shuttle-axum dependency paths in workspace test resources to use version constraints

4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 merged commit 72a7e3c into shuttle-hq:main Jan 9, 2025
25 checks passed
@jonaro00 jonaro00 deleted the axum-0-8 branch January 9, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant