Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default config to exclude ERROR_ROUTES from search and posts #2106

Closed
wants to merge 3 commits into from

Conversation

llllvvuu
Copy link
Contributor

@llllvvuu llllvvuu commented Jul 25, 2023

resolves #2099

  • sets default indexKey for search to exclude ERROR_ROUTES
  • adds type: hidden-page to blog theme
  • adds hiddenPages globs to blog theme; if type is not specified, it will be hidden-page if matching hiddenPages else post
  • sets default hiddenPages for blog to exclude ERROR_ROUTES

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 807cd95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-blog Patch
nextra Patch
nextra-theme-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra ❌ Failed (Inspect) Aug 17, 2023 2:25am
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 2:25am

@vercel
Copy link

vercel bot commented Jul 25, 2023

@llllvvuu is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@llllvvuu llllvvuu force-pushed the fix/exclude_404_from_search branch from e792a86 to a692c12 Compare July 25, 2023 12:51
@llllvvuu llllvvuu force-pushed the fix/exclude_404_from_search branch 2 times, most recently from d9d4123 to 702dd0f Compare July 25, 2023 13:49
@llllvvuu llllvvuu changed the title fix: exclude 404.mdx from search and posts fix: default to exclude 404.mdx from search and posts Jul 25, 2023
@llllvvuu llllvvuu changed the title fix: default to exclude 404.mdx from search and posts fix: default config to exclude 404.mdx from search and posts Jul 25, 2023
@llllvvuu llllvvuu force-pushed the fix/exclude_404_from_search branch from 702dd0f to 6301e9a Compare July 25, 2023 13:57
@llllvvuu llllvvuu changed the title fix: default config to exclude 404.mdx from search and posts fix: default config to exclude /404 from search and posts Jul 25, 2023
Copy link
Contributor

@C-EO C-EO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@llllvvuu llllvvuu changed the title fix: default config to exclude /404 from search and posts fix: default config to exclude ERROR_ROUTES from search and posts Aug 17, 2023
@dimaMachina
Copy link
Collaborator

dimaMachina commented Aug 19, 2023

closes in favour #2181

Thanks for your attempt, but I will stay with an approach to exclude search indexing by default for 404/500 mdx pages, and about nextra-theme-blog - I am against adding an additional dependency for this case and also you can always use regular jsx/tsx page for 404/500 pages in blog theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: 404 Appears in Results
3 participants