Add NewFromUint64 #352
Merged
Add NewFromUint64 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar to #131 (but less reformat noise), but the other PR also contains a nice fix for clickhouse |
|
Agree, that fix for Clickhouse would be great to introduce in the 1.4.0 release too :3 I think we could merge this PR and I'll ask @Bububuger for the fix in the new PR, so you both could get contributor credits :D |
mwoss
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new constructor
NewFromUint64(uint64), which utilisesbig.Int.SetUint64()existing in Go at least since 1.7 (min supported bydecimal): https://pkg.go.dev/math/big@go1.7#Int.SetUint64Improves tests of existing constructors from signed int, covering the minimal negative value.