Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #210: bug: a.Mod(b) returns a negative number - Solved #215

Closed
wants to merge 2 commits into from

Conversation

ashkanlarni
Copy link

No description provided.

@mwoss
Copy link
Member

mwoss commented Feb 14, 2021

I see your implementation is failing on negative cases (-7.5 mod 2 and -7.5 mod -2. Mod implementation should return 0.5 and -1.5. (current implementation was incorrectly calculating -7.5 mod 2 tho

@mwoss
Copy link
Member

mwoss commented Jan 12, 2024

This issue has been already solved in #258 and #317. Closing.

@mwoss mwoss closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants