Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(README): add passing context value document #1478

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

shirou
Copy link
Owner

@shirou shirou commented Jun 4, 2023

which is introduced by #1439.

@shirou
Copy link
Owner Author

shirou commented Jun 4, 2023

@atoulme Would you be willing to review this PR? My English is not good, so you may rewrite it entirely.

@atoulme
Copy link
Contributor

atoulme commented Jun 4, 2023

My Japanese is worse than your English. Reviewing...

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirou shirou merged commit 1754b81 into master Jun 4, 2023
37 checks passed
@shirou shirou deleted the feature/add_doc_about_ctx branch June 4, 2023 08:32
@shirou
Copy link
Owner Author

shirou commented Jun 4, 2023

Thank you for your quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants