phpcs & phpstan: emulate lowest supported PHP version (#200)

shipmonk-rnd · Dec 27, 2023 · 1a542d3 · 1a542d3
1 parent 6103ed1
commit 1a542d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -21,6 +21,7 @@
     <exclude-pattern>tests/*/data/*</exclude-pattern>
 
     <config name="installed_paths" value="../../slevomat/coding-standard"/>
+    <config name="php_version" value="70400"/>
 
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
     <rule ref="Generic.Classes.DuplicateClassName"/>
@@ -248,9 +249,7 @@
     <rule ref="SlevomatCodingStandard.Arrays.DisallowPartiallyKeyed"/>
     <rule ref="SlevomatCodingStandard.Arrays.TrailingArrayComma"/>
     <rule ref="SlevomatCodingStandard.Classes.BackedEnumTypeSpacing"/>
-    <rule ref="SlevomatCodingStandard.Classes.ModernClassNameReference">
-        <exclude name="SlevomatCodingStandard.Classes.ModernClassNameReference.ClassNameReferencedViaFunctionCall"/> <!-- after bumping to PHP8 -->
-    </rule>
+    <rule ref="SlevomatCodingStandard.Classes.ModernClassNameReference"/>
     <rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility" />
     <rule ref="SlevomatCodingStandard.Classes.ClassStructure">
         <properties>

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -7,6 +7,7 @@ includes:
     - ./rules.neon
 
 parameters:
+    phpVersion: 70400
     paths:
         - src
         - tests
@@ -38,8 +39,6 @@ parameters:
                 ShipMonk\PHPStan\RuleTestCase: RuleTest
         forbidAssignmentNotMatchingVarDoc:
             enabled: false # native check is better now; this rule will be dropped / reworked in 3.0
-        enforceClosureParamNativeTypehint:
-            enabled: false # we support even PHP 7.4, some typehints cannot be used
 
     ignoreErrors:
         -