Update version of read the docs theme #468
Conversation
|
Not all tests will pass because of the bug in the master, this PR is just to correct the readthedocs. |
There was a problem hiding this comment.
This PR is make to correct a bug caused by sphinx, because they removed the style argument in the newest version '7.0', I used this method to fixed the issue (kivy/kivy#8230)
I understand this is a temporary fix, so can you please open an issue to address the 'long term' fix once it is fixed upstream by the sphinx/RTD team? thanks
I think that the newest method should always be good, because I'm now not just pinning a version of Sphinx, but I'm using the newest one for sphinx and sphinx_rtd_themes (as indicated in the newest link that I edited in the description of the PR). If it's not enough, I will open a long term issue ! (I converted this PR to a draft one to give me some time to make sure that it's perfect) |
po09i
changed the title
* Update dcm2bids config fiel to follow 3.0.1 convention * Update dcm2bids to version 3.0.1 * Update failing test * Update version of read the docs theme (#468) * Changed version of Sphinx to be able to used style * Changed version of sphinx and sphinx theme --------- Co-authored-by: Aurélien Pujol <63396133+Aurelienpujolm@users.noreply.github.com>
Checklist
Description
This PR is made to correct a bug caused by sphinx, because they removed the style argument in the newest version '7.0', I used this method to fix the issue (readthedocs/sphinx_rtd_theme#1465)