Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deselection of the preselected group values #1750

Closed

Conversation

chandrabhan-singh-27d
Copy link

@chandrabhan-singh-27d chandrabhan-singh-27d commented Feb 5, 2024

Issues:

  1. The custom event 'remove' is not working when emitted from inside the selectGroup method, thus need to call the removeElement method instead.

  2. When removing an element, there is a deep comparison of objects thus need to compare using the JSON.stringify method and then remove the elements from the internalValue array.

Fixes #713

@akki-jat
Copy link
Collaborator

akki-jat commented Feb 8, 2024

@chandrabhan-singh-27d Is there any open issue for the same with the reproducible link. If not then please create the issue first, then we can look into it.

Thanks for the PR.

@chandrabhan-singh-27d
Copy link
Author

@chandrabhan-singh-27d Is there any open issue for the same with the reproducible link. If not then please create the issue first, then we can look into it.

Thanks for the PR.

Hi @akki-jat, please find the issue #713. Thanks!

@chandrabhan-singh-27d
Copy link
Author

Hi @akki-jat, just checking if we can merge this as we are using the library in our app in productions and a quick merge can help us minimizing the fix replication at each instance. As mentioned earlier, here is the issue #713. Appreciate the help!

@akki-jat
Copy link
Collaborator

Closing as we have new PR (#1754) for the same.

@akki-jat akki-jat closed this Feb 19, 2024
@akki-jat
Copy link
Collaborator

@chandrabhan-singh-27d Please check if PR #1754 fixes the issue or not.

@chandrabhan-singh-27d
Copy link
Author

Yes, it does. Thanks for fixing the issue @akki-jat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deselecting pre-selected group
2 participants