chore: update shelljs and drop old node support #228
Merged
+9
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the ShellJS peer dependency to the latest release. This also drops support for all node versions prior to v18 to match ShellJS's version range. This includes some changes due to the latest shelljs version: * `shx sed -i` will now run silently. This is compatible with unix behavior. See shelljs/shelljs#959 * `shx --version` no longer prints the ShellJS version. This is a consequence of the switch to an explicit "exports" list in shelljs (see shelljs/shelljs#1195 and shelljs/shelljs#1135). Test: npm test
nfischer
force-pushed
the
chore-update-shelljs
branch
from
dfbc822 to
76a55a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 114 113 -1
=========================================
- Hits 114 113 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nfischer
added a commit
that referenced
this pull request
Mar 17, 2025
This is a small fix for the `--version` flag. This adds back ShellJS version number, which was re-exposed in PR shelljs/shelljs#1200. This reverts one of the workarounds added in PR #228. This also commits package-lock.json to the repo.
nfischer
added a commit
that referenced
this pull request
Mar 17, 2025
This is a small fix for the `--version` flag. This adds back ShellJS version number, which was re-exposed in PR shelljs/shelljs#1200. This reverts one of the workarounds added in PR #228. This also commits package-lock.json to the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ShellJS peer dependency to the latest release. This also drops support for all node versions prior to v18 to match ShellJS's version range.
This includes some changes due to the latest shelljs version:
shx sed -iwill now run silently. This is compatible with unix behavior. See sed with -i option now runs silently shelljs#959shx --versionno longer prints the ShellJS version. This is a consequence of the switch to an explicit "exports" list in shelljs (see ERR_PACKAGE_PATH_NOT_EXPORTED for shelljs/plugin and shelljs/global shelljs#1195 and Exports shell.js and make.js on package.json shelljs#1135).Test: npm test