Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change GitHub Actions README badge #216

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Aug 5, 2023

This changes the README to use a standard shields.io badge for GitHub
Actions. The custom badge
(https://github.com/Atrox/github-actions-badge) was cool, but the
atrox.dev link doesn't work reliably. I noticed that shields has support
for this now, so there's no reason to use a custom badge.

One notably difference is that this badge says the build is passing even
if there's a job still in progress.

@nfischer nfischer added the docs label Aug 5, 2023
@nfischer nfischer force-pushed the fix-shields-badge branch from 5fb3fdc to cba518c Compare August 5, 2023 20:59
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7442e02) 100.00% compared to head (bfb5740) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          114       114           
=========================================
  Hits           114       114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfischer nfischer force-pushed the fix-shields-badge branch from cba518c to e7ddba9 Compare August 5, 2023 21:03
This changes the README to use a standard shields.io badge for GitHub
Actions. The custom badge
(https://github.com/Atrox/github-actions-badge) was cool, but the
atrox.dev link doesn't work reliably. I noticed that shields has support
for this now, so there's no reason to use a custom badge.

One notably difference is that this badge says the build is passing even
if there's a job still in progress.
@nfischer nfischer force-pushed the fix-shields-badge branch from e7ddba9 to bfb5740 Compare August 5, 2023 21:12
@nfischer nfischer changed the title docs: use standard GitHub Actions badge docs: change GitHub Actions README badge Aug 5, 2023
@nfischer
Copy link
Member Author

nfischer commented Aug 5, 2023

Here's a preview of the badge:

GitHub Actions

@nfischer nfischer merged commit 88de24f into main Aug 5, 2023
@nfischer nfischer deleted the fix-shields-badge branch August 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant