Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated use of xgboost early_stopping_rounds #3306

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

CloseChoice
Copy link
Collaborator

Overview

Closes #3290

Description of the changes proposed in this pull request:

  • move early_stopping_rounds param in instance creation of XGBoost

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@connortann connortann added the bug Indicates an unexpected problem or unintended behaviour label Oct 4, 2023
@connortann connortann changed the title add test clustering Fix deprecated use of xgboost early_stopping_rounds Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d2526da) 57.73% compared to head (5e6b3e2) 58.07%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
+ Coverage   57.73%   58.07%   +0.33%     
==========================================
  Files          89       89              
  Lines       12548    12548              
==========================================
+ Hits         7245     7287      +42     
+ Misses       5303     5261      -42     
Files Coverage Δ
shap/utils/_clustering.py 61.34% <100.00%> (+28.57%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for another good PR

@connortann connortann merged commit 5121282 into shap:master Oct 5, 2023
13 checks passed
@CloseChoice CloseChoice deleted the fix/early-stopping-rounds branch October 5, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: hclust: xgboost early_stopping_rounds deprecated in fit
2 participants