Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Refactor nb/census income xgboost #3282

Merged

Conversation

CloseChoice
Copy link
Collaborator

Overview

Works towards #3036

Description of the changes proposed in this pull request:

  • clean up Census XGBoost notebook. There was not much to do, just remove some unnecessary commands and one typo

Checklist

@connortann
Copy link
Collaborator

Thanks for the PR! A few comments from an initial look:

  1. It looks like there are several warnings in the new rendered notebook, which should be addressed. I think these are related to 3rd party libraries like pandas- downgrading to pandas 1.x may help.
  2. On a minor style note, may I suggest keeping the cell execution numbers? I think it looks visually nicer, and confirms to us maintainers that the notebook was run sequentially top-to-bottom in one run.

@connortann connortann added the documentation Relating to readthedocs, notebooks, and exposition in docstrings label Sep 27, 2023
@CloseChoice
Copy link
Collaborator Author

Thanks for the review. I updated the notebook and fixed most of the warnings. There is still the "invalid value encountered in divide" error, but I cannot fix this with downgrading pandas.

Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

@connortann connortann merged commit f52a80e into shap:master Oct 3, 2023
2 checks passed
@connortann connortann changed the title Refactor nb/census income xgboost DOCS: Refactor nb/census income xgboost Oct 3, 2023
@CloseChoice CloseChoice deleted the refactor-nb/census-income-xgboost branch October 3, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to readthedocs, notebooks, and exposition in docstrings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants