Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: update deprecated numpy param and add links to articles #3201

Merged
merged 1 commit into from
Aug 22, 2023
Merged

DOCS: update deprecated numpy param and add links to articles #3201

merged 1 commit into from
Aug 22, 2023

Conversation

arshiaar
Copy link
Contributor

Overview

Part of #3036

Description of the changes proposed in this pull request:

  • Updated deprecated param name 'interopolation' with 'method' for np.nanpercentile
  • Added links github and medium article.
  • Verified notebook runs and produces correct output.

Issues:

  • Attempted to clear kernel metadata using nb-clean
  • Legend cut off for one graph

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@arshiaar arshiaar marked this pull request as ready for review August 21, 2023 07:01
@dsgibbons
Copy link
Collaborator

I found it a bit difficult to diff this notebook. I found the easiest method so far is to "Review in codespace", select "GitHub Pull Request" (bottom far-left tab), then select the notebook.

dsgibbons
dsgibbons approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@dsgibbons dsgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for your contribution!

@dsgibbons dsgibbons merged commit bfdc55d into shap:master Aug 22, 2023
2 checks passed
@connortann connortann changed the title refactor: update deprecated np param and add links to articles DOCS: update deprecated numpy param and add links to articles Sep 28, 2023
@connortann connortann added the documentation Relating to readthedocs, notebooks, and exposition in docstrings label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgibbons dsgibbons dsgibbons approved these changes

Assignees
No one assigned
Labels
documentation Relating to readthedocs, notebooks, and exposition in docstrings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arshiaar @dsgibbons @connortann