Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all tqdm imports with tqdm.auto #3199

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

owenlamont
Copy link
Contributor

Overview

Description of the changes proposed in this pull request:

I replaced all tqdm imports in modules with tqdm.auto so they wouldn't raise warnings when importing shap in a notebook environment. This was the old warning I was trying to resolve:

image

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@dsgibbons
Copy link
Collaborator

Thank you for your contribution @owenlamont - can you please reformat the PR to use a code block instead of an image so it is easier to run?

@owenlamont
Copy link
Contributor Author

Apologies yes, there was a bunch of superfluous lines in that screenshot, it's really just:

import shap

The warning appears when just importing shap in Jupyter lab.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (bbee378) 57.53% compared to head (4a3d088) 57.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3199   +/-   ##
=======================================
  Coverage   57.53%   57.53%           
=======================================
  Files          88       88           
  Lines       12511    12511           
=======================================
  Hits         7198     7198           
  Misses       5313     5313           
Files Changed Coverage Δ
shap/benchmark/measures.py 0.00% <0.00%> (ø)
shap/benchmark/_explanation_error.py 11.36% <100.00%> (ø)
shap/explainers/_linear.py 82.02% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsgibbons
Copy link
Collaborator

I haven't been able to replicate this warning on my machine yet, but it doesn't seem to have impacted the test suite. LGTM!

@dsgibbons dsgibbons self-requested a review August 22, 2023 01:11
@dsgibbons dsgibbons merged commit 97e6488 into shap:master Aug 22, 2023
15 checks passed
@connortann connortann added the enhancement Indicates new feature requests label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants