add signature type retrieval functions #2164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expose NID in ossl102
sfackler
reviewed
Feb 10, 2024
- add more explicit comments
- refer to signature scheme instead of "signature algorithm" to try and reduce ambiguity.
|
Hi @sfackler! Could I have another review on this? |
|
Hi, @sfackler ,sorry for the ping but I was wondering if you have had a chance to look at this? Thanks! |
|
Hi @sfackler ! I apologize for another ping, but I was wondering if you might be able to take a look at this? I'd love to get this merged in, and I'm very happy to address any feedback that you might have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bindings for signature retrieval apis. I also added a unit test to make sure that basic functionality is working.
https://www.openssl.org/docs/man1.1.1/man3/SSL_get_peer_signature_type_nid.html
History
I dug through the git branch to find the first branch that the various APIs appeared in.