Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken link for Windows MSVC build failures, and explicitly document vcpkg/MSYS2 pacman commands #2139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 13 additions & 4 deletions openssl-sys/build/find_normal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,25 @@ and try building this crate again.
msg.push_str(
"
It looks like you're compiling for MSVC but we couldn't detect an OpenSSL
installation. If there isn't one installed then you can try the rust-openssl
README for more information about how to download precompiled binaries of
OpenSSL:
installation with vcpkg. Make sure you've installed the `openssl` package with
a triplet ending in `-windows-static-md`.

https://github.com/sfackler/rust-openssl#windows
See the error output above for which triplet `vcpkg` tried to use.

",
);
}

msg.push_str(
"
See the `rust-openssl` documentation for more information on how to provide a
compatible version of OpenSSL to link against:

https://docs.rs/openssl/latest/openssl/#building

",
);

panic!("{}", msg);
}

Expand Down
6 changes: 6 additions & 0 deletions openssl/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@
//! # macOS (pkgsrc)
//! $ sudo pkgin install openssl
//!
//! # Windows (vcpkg) for static MSVC targets, install the architecture(s) you need
//! > vcpkg install openssl:x64-windows-static-md openssl:x86-windows-static-md openssl:arm64-windows-static-md
//!
//! # Windows (MSYS2) for MinGW targets
//! $ pacman -S openssl-devel pkg-config
//!
//! # Arch Linux
//! $ sudo pacman -S pkg-config openssl
//!
Expand Down