Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20231030 2059 pkcs11 #2077

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Firstyear
Copy link

Fixes #2059 - This allows loading a PKey from a store by uri. I have already tested this as working with a pkcs11 tpm provider.

I have some questions about how to get this to a "mergeable" state.

  • Do you have a preferred method for running tests for a feature like this, especially where there are external requirements like pkcs11?
  • Is the approach in the handwritten section correct for ffi?
  • I'm not sure how you would like the api structured generally in Store - Stores can be re-used so I could make this use new(uri) instead and then have methods for get_private_key / get_public_key. So some advice on how to shape the api would be good.

I think after this the next step will be to allow creating keys with propqueries per https://github.com/latchset/pkcs11-provider/blob/main/tests/tgenkey.c#L141

@Firstyear
Copy link
Author

@WolfDan

mvar-ms pushed a commit to mvar-ms/rust-openssl that referenced this pull request Nov 29, 2023
@Firstyear
Copy link
Author

Is it possible to get someone to look at this, as I'd like to be able to contribute this.

mvar-ms pushed a commit to mvar-ms/rust-openssl that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to provide a URI to create a PKey?
1 participant