Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'possible LibreSSL bug' #2062

Merged
merged 1 commit into from Oct 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions openssl/src/ssl/test/mod.rs
Expand Up @@ -1023,7 +1023,9 @@ fn idle_session() {
assert!(ssl.session().is_none());
}

/// possible LibreSSL bug since 3.2.1
/// LibreSSL 3.2.1 enabled TLSv1.3 by default for clients and sessions do
/// not work due to lack of PSK support. The test passes with NO_TLSV1_3,
/// but let's ignore it until LibreSSL supports it out of the box.
#[test]
#[cfg_attr(libressl321, ignore)]
fn active_session() {
Expand Down Expand Up @@ -1081,7 +1083,9 @@ fn status_callbacks() {
assert!(CALLED_BACK_CLIENT.load(Ordering::SeqCst));
}

/// possible LibreSSL bug since 3.2.1
/// LibreSSL 3.2.1 enabled TLSv1.3 by default for clients and sessions do
/// not work due to lack of PSK support. The test passes with NO_TLSV1_3,
/// but let's ignore it until LibreSSL supports it out of the box.
#[test]
#[cfg_attr(libressl321, ignore)]
fn new_session_callback() {
Expand All @@ -1106,7 +1110,9 @@ fn new_session_callback() {
assert!(CALLED_BACK.load(Ordering::SeqCst));
}

/// possible LibreSSL bug since 3.2.1
/// LibreSSL 3.2.1 enabled TLSv1.3 by default for clients and sessions do
/// not work due to lack of PSK support. The test passes with NO_TLSV1_3,
/// but let's ignore it until LibreSSL supports it out of the box.
#[test]
#[cfg_attr(libressl321, ignore)]
fn new_session_callback_swapped_ctx() {
Expand Down