Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type-safe wrappers instead of EVP_PKEY_assign #1959

Merged
merged 1 commit into from Jun 8, 2023
Merged

Use type-safe wrappers instead of EVP_PKEY_assign #1959

merged 1 commit into from Jun 8, 2023

Commits on Jun 8, 2023

  1. Use type-safe wrappers instead of EVP_PKEY_assign 

    In OpenSSL, these are macros, so they didn't get imported by bindgen,
but they're proper functions in BoringSSL and we'd prefer
callers use those for safety. For OpenSSL, just add the corresponding
functions in openssl-sys, matching how rust-openssl handles
EVP_PKEY_CTX_ctrl.

Using the type-safe wrappers flags that rust-openssl was trying to
convert DH to EVP_PKEY, but BoringSSL doesn't actually support this. (DH
is a legacy primitive, so we haven't routed it to EVP_PKEY right now.)
    @davidben
    davidben committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c2f4d58 View commit details
    Browse the repository at this point in the history