Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for EVP_PKEY_derive_set_peer_ex in OpenSSL 3 #1956

Merged
merged 5 commits into from Jun 7, 2023
Merged

add support for EVP_PKEY_derive_set_peer_ex in OpenSSL 3 #1956

merged 5 commits into from Jun 7, 2023

Conversation

reaperhulk
Copy link
Contributor

via Deriver::set_peer_ex

alex
alex reviewed Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfackler anything to be done by way of naming convention here?

impl lgtm

sfackler
sfackler reviewed Jun 7, 2023
View reviewed changes
openssl/src/derive.rs Outdated Show resolved Hide resolved
@sfackler
Copy link
Owner

sfackler commented Jun 7, 2023

Naming seems fine to me

@reaperhulk @sfackler
Update openssl/src/derive.rs
45e4fc2 
Co-authored-by: Steven Fackler <sfackler@gmail.com>
@alex alex merged commit a71f492 into sfackler:master Jun 7, 2023
53 checks passed
@reaperhulk reaperhulk deleted the ex-tend-those-peers branch June 7, 2023 06:41
@beaufour beaufour mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler left review comments

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reaperhulk @sfackler @alex