Skip to content

Commit

Permalink
Merge pull request #2062 from botovq/psk
Browse files Browse the repository at this point in the history
Clarify 'possible LibreSSL bug'
  • Loading branch information
sfackler committed Oct 20, 2023
2 parents ca8fc70 + 6218635 commit 0917bed
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions openssl/src/ssl/test/mod.rs
Expand Up @@ -1023,7 +1023,9 @@ fn idle_session() {
assert!(ssl.session().is_none());
}

/// possible LibreSSL bug since 3.2.1
/// LibreSSL 3.2.1 enabled TLSv1.3 by default for clients and sessions do
/// not work due to lack of PSK support. The test passes with NO_TLSV1_3,
/// but let's ignore it until LibreSSL supports it out of the box.
#[test]
#[cfg_attr(libressl321, ignore)]
fn active_session() {
Expand Down Expand Up @@ -1081,7 +1083,9 @@ fn status_callbacks() {
assert!(CALLED_BACK_CLIENT.load(Ordering::SeqCst));
}

/// possible LibreSSL bug since 3.2.1
/// LibreSSL 3.2.1 enabled TLSv1.3 by default for clients and sessions do
/// not work due to lack of PSK support. The test passes with NO_TLSV1_3,
/// but let's ignore it until LibreSSL supports it out of the box.
#[test]
#[cfg_attr(libressl321, ignore)]
fn new_session_callback() {
Expand All @@ -1106,7 +1110,9 @@ fn new_session_callback() {
assert!(CALLED_BACK.load(Ordering::SeqCst));
}

/// possible LibreSSL bug since 3.2.1
/// LibreSSL 3.2.1 enabled TLSv1.3 by default for clients and sessions do
/// not work due to lack of PSK support. The test passes with NO_TLSV1_3,
/// but let's ignore it until LibreSSL supports it out of the box.
#[test]
#[cfg_attr(libressl321, ignore)]
fn new_session_callback_swapped_ctx() {
Expand Down

0 comments on commit 0917bed

Please sign in to comment.