fix: improve login/connect flow

[janb87]

Summary by Sourcery

Enhancements:

• Use a consistent default instance across login and connect prompts.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request improves the login/connect flow by prioritizing the instance used for login when prompting the user for an instance URL.

Sequence diagram for improved login/connect flow

Loading

sequenceDiagram
    actor User
    participant CLI
    participant InstancePrompt
    participant EnvLoader

    User->>CLI: Initiates login/connect
    CLI->>EnvLoader: loadEnv()
    CLI->>InstancePrompt: instancePrompt()
    InstancePrompt->>InstancePrompt: getDefaultInstance()
    alt Has SETTLEMINT_INSTANCE env var
        InstancePrompt-->>CLI: Return env instance
    else No env var but has default login instance
        InstancePrompt-->>CLI: Return default login instance
    else No defaults
        InstancePrompt->>User: Prompt for instance URL
        User->>InstancePrompt: Provide URL
        InstancePrompt-->>CLI: Return provided URL
    end
    CLI-->>User: Continue with login process

Flow diagram for instance URL resolution

Loading

flowchart TD
    A[Start] --> B{Has SETTLEMINT_INSTANCE?}
    B -->|Yes| C[Use env instance]
    B -->|No| D{Has default login instance?}
    D -->|Yes| E[Use default login instance]
    D -->|No| F{Free text input enabled?}
    F -->|Yes| G[Show text input prompt]
    F -->|No| H[Show instance selection list]
    G --> I[Validate URL]
    H --> I
    I --> J[Return instance URL]

File-Level Changes

Change	Details	Files
Prioritize login instance for default prompt value	Use the login instance as the default value when prompting for the SettleMint instance URL. Remove validation of the instance URL in the login command since it is now handled in the instance prompt. Use a default instance URL if available from environment variables or known instances, or from the login process as a fallback. Update the instance prompt to use the default instance URL if available, or "https://console.settlemint.com" as a last resort.	sdk/cli/src/commands/connect/instance.prompt.ts sdk/cli/src/commands/login.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @janb87 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Review instructions: 2 issues found
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

📦 Packages

Package	NPM	Docker
SDK Cli	@settlemint/sdk-cli@1.0.0-pr895881b7
SDK The Graph	@settlemint/sdk-thegraph@1.0.0-pr895881b7
SDK Portal	@settlemint/sdk-portal@1.0.0-pr895881b7
SDK Hasura	@settlemint/sdk-hasura@1.0.0-pr895881b7
SDK JS	@settlemint/sdk-js@1.0.0-pr895881b7
SDK Utils	@settlemint/sdk-utils@1.0.0-pr895881b7
SDK Next	@settlemint/sdk-next@1.0.0-pr895881b7
SDK Minio	@settlemint/sdk-minio@1.0.0-pr895881b7
SDK IPFS	@settlemint/sdk-ipfs@1.0.0-pr895881b7
SDK Blockscout	@settlemint/sdk-blockscout@1.0.0-pr895881b7