-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e tests #521
Merged
Merged
fix: e2e tests #521
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request fixes end-to-end tests by adding the Sequence diagram for the updated instance prompt flowsequenceDiagram
participant CLI
participant Env
participant User
CLI->>Env: loadEnv()
Env-->>CLI: env configuration
Note over CLI: Removed redundant env check
CLI->>User: instancePrompt()
User-->>CLI: instance selection
alt usePersonalAccessToken
CLI->>CLI: getInstanceCredentials(instance)
CLI-->>CLI: personalAccessToken
else
CLI->>Env: get SETTLEMINT_ACCESS_TOKEN
Env-->>CLI: accessToken
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @janb87 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
📦 Packages
|
snigdha920
approved these changes
Dec 21, 2024
snigdha920
added a commit
that referenced
this pull request
Dec 21, 2024
Loading
Loading status checks…
…t-else-use-the-pat-token-for * main: chore: update package versions [skip ci] chore(deps): update oven/bun docker tag to v1.1.42 (#527) fix: e2e tests (#521) chore(deps): update dependency @inquirer/input to v4.1.1 (#523) chore(deps): update dependency react-hook-form to v7.54.2 (#526) chore(deps): update dependency @inquirer/select to v4.0.4 (#525) chore(deps): update dependency @inquirer/password to v4.0.4 (#524) chore(deps): update dependency @inquirer/confirm to v5.1.1 (#522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--wait
is needed for the codegen command to work (eg if the graphql api is not running the codegen cannot download the schema)Summary by Sourcery
Tests: