feat: command to create node from existing network, fix select node & pk e2e test

[snigdha920]

Summary by Sourcery

Add support for creating blockchain nodes from the CLI. Update the select node and private key E2E test to reflect the new node creation options.

New Features:

• Add a command to create a new Besu blockchain node.

Tests:

• Update E2E tests to include node selection and private key selection during smart contract set deployment.

[linear]

ENG-2037 Command to create node from existing network

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new command that allows users to create a blockchain node from an existing network. It also includes updates to the select node and private key end-to-end tests to reflect the new functionality and changes to the graph middleware create command to no longer require a storage ID.

Sequence diagram for creating a blockchain node from existing network

Loading

sequenceDiagram
    actor User
    participant CLI
    participant SettleMint
    participant Network

    User->>CLI: Execute create blockchain-node command
    alt No application specified
        CLI-->>User: Request application ID
    end
    alt No network specified
        CLI->>SettleMint: Get available networks
        SettleMint-->>CLI: Return networks list
        CLI-->>User: Prompt to select network
    end
    User->>CLI: Provide node configuration
    CLI->>SettleMint: Create blockchain node
    SettleMint->>Network: Add node to network
    Network-->>SettleMint: Confirm node creation
    SettleMint-->>CLI: Return node details
    CLI-->>User: Display success and update env

Class diagram for the new blockchain node creation commands

Loading

classDiagram
    class Command {
        +alias(string)
        +description(string)
        +addCommand(Command)
        +option(string, string)
        +action(function)
    }

    class BlockchainNodeCreateCommand {
        +alias: 'bn'
        +description: string
    }

    class BlockchainNodeBesuCreateCommand {
        +name: 'besu'
        +alias: 'b'
        +execute(cmd, baseAction)
        -blockchainNetworkPrompt()
    }

    Command <|-- BlockchainNodeCreateCommand
    BlockchainNodeCreateCommand o-- BlockchainNodeBesuCreateCommand

    note for BlockchainNodeBesuCreateCommand "New command for creating
Besu blockchain nodes
from existing networks"

File-Level Changes

Change	Details	Files
Added a new command to create a blockchain node from an existing network.	Added blockchainNodeCreateCommand to the platform create command. Added a new command blockchain-node with the alias bn. Implemented the blockchainNodeBesuCreateCommand function to handle the creation of a Besu node. Added tests for the new command.	sdk/cli/src/commands/platform/create.ts sdk/cli/src/commands/platform/blockchain-node/create.ts sdk/cli/src/commands/platform/blockchain-node/besu/create.ts sdk/cli/src/commands/platform/blockchain-node/besu/create.test.ts
Modified the select node and private key end-to-end tests.	Added setup for two additional nodes: one with an activated private key and one without. Updated the node selection prompt in the tests to include the new nodes. Added constants for the new nodes and private key.	test/scripts/setup-platform-resources.ts test/create-smart-contract-set.e2e.test.ts test/constants/test-resources.ts
Updated the graph middleware create command.	Removed the storage ID requirement when creating a graph middleware.	sdk/cli/src/commands/platform/middleware/graph/create.ts
Modified the blockchain network create command alias.	Changed the alias of the blockchain-network command from bn to bnw.	sdk/cli/src/commands/platform/blockchain-network/create.ts
Modified the create command to use the instance from the environment variables if available.	Use the SETTLEMINT_INSTANCE environment variable if available, otherwise prompt the user for the instance.	sdk/cli/src/commands/platform/common/create-command.ts
Skipped the subgraph deploy test.	Added the skip directive to the subgraph - Deploy subgraphs test.	test/create-new-project.e2e.test.ts
Added a restart command for blockchain nodes.	Implemented the blockchainNodeRestartCommand function to handle restarting a blockchain node.	sdk/cli/src/commands/platform/blockchain-node/restart.ts
Added a prompt for selecting a blockchain network.	Implemented the blockchainNetworkPrompt function to prompt the user for a blockchain network selection.	sdk/cli/src/commands/connect/blockchain-network.prompt.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

📦 Packages

Package	NPM	Docker
SDK Cli	@settlemint/sdk-cli@0.7.0-pr2e7319a
SDK The Graph	@settlemint/sdk-thegraph@0.7.0-pr2e7319a
SDK Portal	@settlemint/sdk-portal@0.7.0-pr2e7319a
SDK Hasura	@settlemint/sdk-hasura@0.7.0-pr2e7319a
SDK JS	@settlemint/sdk-js@0.7.0-pr2e7319a
SDK Utils	@settlemint/sdk-utils@0.7.0-pr2e7319a
SDK Next	@settlemint/sdk-next@0.7.0-pr2e7319a
SDK Minio	@settlemint/sdk-minio@0.7.0-pr2e7319a
SDK IPFS	@settlemint/sdk-ipfs@0.7.0-pr2e7319a
SDK Blockscout	@settlemint/sdk-blockscout@0.7.0-pr2e7319a
Registry		ghcr.io/settlemint/btp-sdk-registry:0.7.0-pr2e7319a

[sourcery-ai]

Hey @snigdha920 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider keeping the deployment status checks (--wait flags and status verification) for resource creation to ensure resources are fully deployed before proceeding. Removing these could lead to race conditions if subsequent operations assume resources are ready.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Review instructions: 2 issues found
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[janb87]

this is redundant, the instanceprompt will automatically return this env variable

[janb87]

keep the wait, eg if we run codegen in a test and the resource is not deployed the test will fail