Move non-gfx things out of gfx_traits and create a base crate
#32296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that |
|
This looks like a large change, but is just moving code around. |
|
🔨 Triggering try run (#9124745964) for Linux WPT, MacOS, Windows, Android |
|
I think we also need to update |
|
Test results for linux-wpt-layout-2013 from try job (#9124745964): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (14)
|
|
Test results for linux-wpt-layout-2020 from try job (#9124745964): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (12)
|
|
|
For a long time, `gfx_traits` has held a lot of things unrelated to graphics and also unrelated to the `gfx` crate (which is mostly about fonts). This is a cleanup which does a few things: 1. Move non `gfx` crate things out of `gfx_traits`. This is important in order to prevent dependency cycles with a different integration between layout, script, and fonts. 2. Rename the `msg` crate to `base`. It didn't really contain anything to do with messages and instead mostly holds ids, which are used across many different crates in Servo. This new crate will hold the *rare* data types that are widely used. Details: - All BackgroundHangMonitor-related things from base to a new `background_hang_monitor_api` crate. - Moved `TraversalDirection` to `script_traits` - Moved `Epoch`-related things from `gfx_traits` to `base`. - Moved `PrintTree` to base. This should be widely useful in Servo. - Moved `WebrenderApi` from `base` to `webrender_traits` and renamed it to `WebRenderFontApi`.
mrobinson
force-pushed
the
gfx-base-reorganization
branch
from
c55ef8e
to
1556405
Compare
I think the Android build should be fixed now. |
|
🔨 Triggering try run (#9127511252) for Linux WPT, MacOS, Windows, Android |
|
Test results for linux-wpt-layout-2013 from try job (#9127511252): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (13)
|
|
Test results for linux-wpt-layout-2020 from try job (#9127511252): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (10)
|
|
✨ Try run (#9127511252) succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time,
gfx_traitshas held a lot of things unrelated to graphicsand also unrelated to the
gfxcrate (which is mostly about fonts).This is a cleanup which does a few things:
gfxcrate things out ofgfx_traits. This is important inorder to prevent dependency cycles with a different integration between
layout, script, and fonts.
msgcrate tobase. It didn't really contain anythingto do with messages and instead mostly holds ids, which are used
across many different crates in Servo. This new crate will hold the
rare data types that are widely used.
Details:
background_hang_monitor_apicrate.TraversalDirectiontoscript_traitsEpoch-related things fromgfx_traitstobase.PrintTreeto base. This should be widely useful in Servo.WebrenderApifrombasetowebrender_traitsand renamed itto
WebRenderFontApi../mach build -ddoes not report any errors./mach test-tidydoes not report any errors