build(deps): bump bitflags from 1.3.2 to 2.3.1

[mrobinson]

Bumps bitflags from 1.3.2 to 2.3.1.

• Release notes
• Changelog
• Commits

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes do not require tests because they do not change behavior.

[mukilan]

I've fixed the tidy issue that failed the build.

[mukilan]

The layout 2013 tests are crashing because it looks like the FlowFlags type in layout/flow.rs has a member TEXT_ALIGN that is used as a bitfield instead of simple flags i.e the code was stashing the numerical value of the TextAlign enum into bits 11-14. However, that code was relying on incorrect behaviour in bitflags where the from_bits method allowed undefined bit combinations to be cast a proper Flag value and this has since been fixed

[mrobinson]

Wow, @mukilan thanks for the great detective work! I'll see what I can do to fix this issue.

[mrobinson]

@bors-servo try=wpt

[github-actions]

🔨 Triggering try run (#6047561649) with platform=linux and layout=2013

[github-actions]

Test results for linux-wpt-layout-2013 from try job (#6047561649):

Flaky unexpected result (12)

• OK /_mozilla/css/stylesheet_media_queries.html (#17159)
  • FAIL [expected PASS] subtest: Media queries within stylesheets assert_equals: expected "rgb(0, 255, 0)" but got "rgb(255, 0, 0)"
• OK /_mozilla/mozilla/task_queue_throttling.any.html (#22519)
  • FAIL [expected PASS] subtest: Throttling the performance timeline task queue. assert_true: expected true got false
• TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
  • NOTRUN [expected PASS] subtest: Overall test
• OK /css/CSS2/linebox/inline-negative-margin-001.html (#23862)
  • FAIL [expected PASS] subtest: [data-expected-height] 1 assert_equals:
    <inline-block data-expected-height="10">123 <span style="margin-left: -8ch">1234 </span></inline-block>
    height expected 10 but got 20
  • FAIL [expected PASS] subtest: [data-expected-height] 2 assert_equals:
    <inline-block data-expected-height="10">123 <span style="margin-left: -8ch">123 </span></inline-block>
    height expected 10 but got 20
  • PASS [expected FAIL] subtest: [data-expected-height] 4
• OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
  • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
• TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
  • TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown Test timed out
• OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if
    allow-popups-to-escape-sandbox is used assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
• OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
  • PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
• OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
  • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
• OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
  • PASS [expected FAIL] subtest: document.write in an imported module
• CRASH [expected OK] /referrer-policy/4K/gen/top.http-rp/origin-when-cross-origin/sharedworker-classic.http.html
• OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
  • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results that are known to be intermittent (18)

• OK /css/css-flexbox/text-as-flexitem-size-001.html (#28726)
  • FAIL [expected PASS] subtest: .flexbox > div 1 assert_equals:
    <div data-expected-width="70" data-expected-height="35">
    <p>xx xxx</p>
    <p>xx</p>
    </div>
    width expected 70 but got 46
  • FAIL [expected PASS] subtest: .flexbox > div 2 assert_equals:
    <div data-expected-width="50" data-expected-height="45">
    <p>xx xxx</p>
    <p>xx</p>
    </div>
    width expected 50 but got 46
  • FAIL [expected PASS] subtest: .flexbox > div 5 assert_equals:
    <div style="height: 30px" data-expected-width="70" data-expected-height="30">
    <p>xx xxx</p>
    <p>xx</p>
    </div>
    width expected 70 but got 46
  • FAIL [expected PASS] subtest: .flexbox > div 8 assert_equals:
    <div style="min-height: 40px" data-expected-width="70" data-expected-height="40">
    <p>xx xxx</p>
    <p>xx</p>
    </div>
    width expected 70 but got 46
  • FAIL [expected PASS] subtest: .flexbox > div 11 assert_equals:
    <div style="max-height: 20px" data-expected-width="70" data-expected-height="20">
    <p>xx xxx</p>
    <p>xx</p>
    </div>
    width expected 70 but got 46
• OK /css/css-fonts/variations/font-weight-matching.html (#20686)
  • FAIL [expected PASS] subtest: Test @font-face matching for weight 100 assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180
• OK /css/cssom-view/scroll-behavior-smooth-navigation.html (#29564)
  • FAIL [expected PASS] subtest: Smooth scrolling while doing history navigation. assert_not_equals: Shouldn't be scrolled to top anymore. got disallowed value 0
• TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.any.html (#29536)
• TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
  • PASS [expected TIMEOUT] subtest: background-image sec-fetch-dest - Not sent to non-trustworthy same-site destination
  • PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
• OK /fetch/private-network-access/worker-blob-fetch.tentative.window.html (#30064)
  • PASS [expected FAIL] subtest: local to local: success.
  • PASS [expected FAIL] subtest: local https to local https: success.
• OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
  • FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked assert_equals: expected "�ÿĀ" but got ""
  • FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked assert_equals: expected "😍" but got ""
  • FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked assert_equals: expected "\ufffdA" but got ""
• OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
  • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted assert_array_equals: Pages opened during history navigation lengths differ, expected array [6, 5] length 2, got [6, 3, 3] length 3
• OK /html/browsers/history/the-location-interface/location-protocol-setter.html (#20839)
  • PASS [expected FAIL] subtest: Equivalent tests for data URL and srcdoc <iframe>s
• OK /html/browsers/the-window-object/open-close/creating_browsing_context_test_01.html (#29046)
  • FAIL [expected PASS] subtest: first argument: absolute url assert_equals: should be equal to result url expected "http://web-platform.test:8000/common/blank.html" but got "about:blank"
• PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
• OK [expected CRASH] /html/canvas/offscreen/the-offscreen-canvas/size.attributes.parse.minus.worker.html (#30164)
• TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-top.html (#28259)
  • TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with "top" fragments should work. Test timed out
• TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/skip-another-top-level-browsing-context.html (#24161)
  • TIMEOUT [expected PASS] subtest: Autofocus elements queued in another top-level browsing context's documents should be skipped. Test timed out
• PASS [expected CRASH] /streams/readable-streams/crashtests/strategy-worker-terminate.html (#30124)
• TIMEOUT [expected OK] /webmessaging/with-ports/017.html (#24486)
  • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out
• OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
  • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
• TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
  • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank Test timed out

[github-actions]

✨ Try run (#6047561649) succeeded.

[mrobinson]

I've just moved the TextAlign data structure out of the flags. This might be a bit less efficient memory-wise, but I think this is okay considering that we are dealing with the legacy layout here.