-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add additional reviewers for rust-url #1048
Conversation
My main issue is the lack of my ability to do "Request reviews" now. |
@bors-servo r+ |
📌 Commit 56be29c has been approved by |
Re-add additional reviewers for rust-url Hey, during the [recent Servo TSC Github permission cleanup](servo/rust-url#839 (comment)), @valenting and I lost access to `rust-url` to do reviews. We have been maintaining it for the past year and a bit, and it would be great to have review access again. Is this the right way?
☔ The latest upstream changes (presumably a15e509) made this pull request unmergeable. Please resolve the merge conflicts. |
💥 Test timed out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell whether this is actually needed.
With the change to use merge queues this will not be needed. |
Great, thanks |
Hey, during the recent Servo TSC Github permission cleanup, @valenting and I lost access to
rust-url
to do reviews. We have been maintaining it for the past year and a bit, and it would be great to have review access again. Is this the right way?