Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null! usages #2029

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Remove null! usages #2029

wants to merge 2 commits into from

Conversation

sungam3r
Copy link
Contributor

They were introduced in #1955.

@nblumhardt
Copy link
Member

Thanks for taking a look at this @sungam3r; hope all is well with you. Reviews are a little behind on this repo currently :-)

These are suppressions for the Rider/ReSharper "Expression is always true or false according to nullable reference types annotations" inspection. We could use a comment for the suppression, but this is really noisy at each point we do it, or switch the inspection off at the file level, but this makes it less obvious that the checks are safety checks for non-NRT-checking callers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants