Fix for missing TraceId and SpanId #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Implement changes from serilog/serilog#1955 |
EEParker
changed the title
|
@EEParker overwriting the current TraceIdentifier won't break anything right? Not an expert on that but that's for the entire request right? Would that affect any other middleware? |
|
Are you referring to the sample app? That is to add a fake traceid since it isn't running aspnetcore. The actual sink is just adding the missing fields from the upstream generic json sink. |
|
I was looking at this on my phone and didn't see what app the file was in, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reproduction for #195 to the sample project.