Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-API migration #2305

Merged
merged 47 commits into from
Dec 11, 2021
Merged

Node-API migration #2305

merged 47 commits into from
Dec 11, 2021

Commits on Nov 26, 2021

  1. Change dependency to napi 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    f61387d View commit details
    Browse the repository at this point in the history

  2. include napi 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    a604ed5 View commit details
    Browse the repository at this point in the history

  3. update shared functionality to NAPI 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    15058ef View commit details
    Browse the repository at this point in the history

  4. win specific changes 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    0ec629f View commit details
    Browse the repository at this point in the history

  5. comment out async resources 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2ab6d14 View commit details
    Browse the repository at this point in the history

  6. initial mac changes for NAPI 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    fcdb5ea View commit details
    Browse the repository at this point in the history

  7. Use include_dir instead of include 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    f6651d6 View commit details
    Browse the repository at this point in the history

  8. Remove unchecked call to napi_* for return args 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    5dabafc View commit details
    Browse the repository at this point in the history

  9. update unix methods to include napi_env 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b6e3d41 View commit details
    Browse the repository at this point in the history

  10. Initial poller conversion (v broken) 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    6b72730 View commit details
    Browse the repository at this point in the history

  11. Fix setBaton (revert bug) 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c01113d View commit details
    Browse the repository at this point in the history

  12. fix for include_dirs 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4350078 View commit details
    Browse the repository at this point in the history

  13. Convert OpenBaton to AsyncWorker 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8b37af1 View commit details
    Browse the repository at this point in the history

  14. SetError within Execute() 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    d5b8185 View commit details
    Browse the repository at this point in the history

  15. Replace napi_create_async_work for common methods 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    6118528 View commit details
    Browse the repository at this point in the history

  16. Comment update - AsyncResource -> AsyncWorker 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    426d7e9 View commit details
    Browse the repository at this point in the history

  17. Update node-abi dependency 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    03c4d7b View commit details
    Browse the repository at this point in the history

  18. fix Get 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    23e8629 View commit details
    Browse the repository at this point in the history

  19. Update List 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    d5ec10b View commit details
    Browse the repository at this point in the history

  20. initial update of read and write (win) 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    5500e29 View commit details
    Browse the repository at this point in the history

  21. fix linux errors 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    7aac610 View commit details
    Browse the repository at this point in the history

  22. use void baton inheritance 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    deaea83 View commit details
    Browse the repository at this point in the history

  23. Consistently pass callback to baton 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c7c2b5c View commit details
    Browse the repository at this point in the history

  24. Some poller patches 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    7f3220b View commit details
    Browse the repository at this point in the history

  25. remove redundant ByteSize Setting 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    afb6371 View commit details
    Browse the repository at this point in the history

  26. fix typo 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    5eebb78 View commit details
    Browse the repository at this point in the history

  27. NODE_ADDON_API_ENABLE_MAYBE 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    be974d9 View commit details
    Browse the repository at this point in the history

  28. some poller fixes 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    06c612d View commit details
    Browse the repository at this point in the history

  29. reinstate setBaudRate 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    85635f8 View commit details
    Browse the repository at this point in the history

  30. fix ConnectionOptionsBaton 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4e3d595 View commit details
    Browse the repository at this point in the history

  31. optional - remove warnings 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    82575c3 View commit details
    Browse the repository at this point in the history

  32. Remove OnError logic 

    Comment out OnError logic
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    a1cca06 View commit details
    Browse the repository at this point in the history

  33. Fix linting errors 

    mac errors, override Execute()
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8383df4 View commit details
    Browse the repository at this point in the history

  34. linting errors part 2

    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    1a09db0 View commit details
    Browse the repository at this point in the history

  35. linting errors part 3

    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    57237f3 View commit details
    Browse the repository at this point in the history

  36. package updates 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c051b7f View commit details
    Browse the repository at this point in the history

  37. enable exceptions 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4bab582 View commit details
    Browse the repository at this point in the history

  38. poller fixes 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2ee143d View commit details
    Browse the repository at this point in the history

  39. node-abi update 

    Signed-off-by: Gareth Hancock <gazhank@gmail.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3ab5148 View commit details
    Browse the repository at this point in the history

  40. Low Latency fix 

    Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    540da10 View commit details
    Browse the repository at this point in the history

  41. package-lock fix 

    Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2bbd67a View commit details
    Browse the repository at this point in the history

  42. Revert loackfile to v1 

    Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    70a75b2 View commit details
    Browse the repository at this point in the history

  43. Cleanup OnError comments 

    Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    64e8104 View commit details
    Browse the repository at this point in the history

  44. Fix Windows Read and Write 

    Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    42d87d1 View commit details
    Browse the repository at this point in the history

  45. Fix no COM port serialport#2325 

    Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
    @GazHank @reconbot
    GazHank authored and reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3950949 View commit details
    Browse the repository at this point in the history

  46. fix locks

    @reconbot
    reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    e0e9b52 View commit details
    Browse the repository at this point in the history

  47. fix: locks

    @reconbot
    reconbot committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    e300c78 View commit details
    Browse the repository at this point in the history