Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated type for storing image hashes #2462

Merged
merged 11 commits into from
Jun 13, 2023

Conversation

GnomedDev
Copy link
Member

This converts the hex representation that is used across the API into a much smaller (56 vs 17) type which improves type safety, saves space, and reduces heap allocations (only during a clone, but deserialization could be made work without an allocation if we pull in an ArrayString dependency).

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!
@github-actions github-actions bot added builder Related to the `builder` module. cache Related to the `cache`-feature. model Related to the `model` module. labels Jun 11, 2023

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jun 12, 2023
src/model/guild/mod.rs Outdated Show resolved Hide resolved
src/model/misc.rs Outdated Show resolved Hide resolved
src/model/misc.rs Show resolved Hide resolved
src/model/misc.rs Outdated Show resolved Hide resolved
src/model/misc.rs Show resolved Hide resolved
src/model/misc.rs Show resolved Hide resolved
GnomedDev and others added 7 commits June 12, 2023 19:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!
This is untested as I do not have access to it.

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!
This removes the weird case of an input of length 34 being a different error case

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!
@GnomedDev GnomedDev requested a review from arqunis June 12, 2023 23:54

Verified

This commit was signed with the committer’s verified signature.
GnomedDev Gnome!
@arqunis arqunis merged commit 9ea3660 into serenity-rs:next Jun 13, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
This converts the hex representation that is used across the API into a much smaller (56 vs 17) type which improves type safety, saves space, and reduces heap allocations (only during a clone).
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
This converts the hex representation that is used across the API into a much smaller (56 vs 17) type which improves type safety, saves space, and reduces heap allocations (only during a clone).
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
This converts the hex representation that is used across the API into a much smaller (56 vs 17) type which improves type safety, saves space, and reduces heap allocations (only during a clone).
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
This converts the hex representation that is used across the API into a much smaller (56 vs 17) type which improves type safety, saves space, and reduces heap allocations (only during a clone).
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
This converts the hex representation that is used across the API into a much smaller (56 vs 17) type which improves type safety, saves space, and reduces heap allocations (only during a clone).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. cache Related to the `cache`-feature. enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants