Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom enum for Nonce instead of Value #1990

Merged
merged 2 commits into from
Jun 19, 2022

Conversation

GnomedDev
Copy link
Member

This narrows the type it can be, speeds up deserialization, and reduces the size of Message slightly

@github-actions github-actions bot added cache Related to the `cache`-feature. model Related to the `model` module. utils Related to the `utils` module. labels Jun 18, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nickelc nickelc added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jun 18, 2022
@nickelc nickelc merged commit 2daf3da into serenity-rs:next Jun 19, 2022
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 19, 2022
nickelc pushed a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
nickelc pushed a commit to nickelc/serenity that referenced this pull request Jul 4, 2022
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jul 20, 2022
arqunis pushed a commit to arqunis/serenity that referenced this pull request Sep 2, 2022
kangalio pushed a commit to kangalio/serenity that referenced this pull request Sep 11, 2022
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 1, 2022
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. enhancement An improvement to Serenity. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants