Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new dead_code warning in tuple struct and tuple variant remote defs #2671

Merged
merged 3 commits into from Jan 6, 2024
Merged

Fix new dead_code warning in tuple struct and tuple variant remote defs #2671

merged 3 commits into from Jan 6, 2024

Commits on Jan 6, 2024

  1. Add FIXME to fix dead_code warning when using serde(remote) 

        warning: field `0` is never read
       --> test_suite/tests/test_remote.rs:143:24
        |
    143 | struct PrimitivePubDef(u8);
        |        --------------- ^^
        |        |
        |        field in this struct
        |
        = note: `#[warn(dead_code)]` on by default
    help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
        |
    143 | struct PrimitivePubDef(());
        |                        ~~

    warning: field `0` is never read
       --> test_suite/tests/test_remote.rs:162:20
        |
    162 | struct TuplePubDef(u8, #[serde(with = "UnitDef")] remote::Unit);
        |        ----------- ^^
        |        |
        |        field in this struct
        |
    help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
        |
    162 | struct TuplePubDef((), #[serde(with = "UnitDef")] remote::Unit);
        |                    ~~

    warning: field `0` is never read
       --> test_suite/tests/test_remote.rs:200:13
        |
    200 |     Variant(u8),
        |     ------- ^^
        |     |
        |     field in this variant
        |
    help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
        |
    200 |     Variant(()),
        |             ~~

    error: field `0` is never read
       --> test_suite/tests/test_gen.rs:390:23
        |
    390 |     struct StrDef<'a>(&'a str);
        |            ------     ^^^^^^^
        |            |
        |            field in this struct
        |
    note: the lint level is defined here
       --> test_suite/tests/test_gen.rs:5:9
        |
    5   | #![deny(warnings)]
        |         ^^^^^^^^
        = note: `#[deny(dead_code)]` implied by `#[deny(warnings)]`
    help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
        |
    390 |     struct StrDef<'a>(());
        |                       ~~
    @dtolnay
    dtolnay committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    6f1a8c3 View commit details
    Browse the repository at this point in the history

  2. Fix new dead_code warning in tuple struct and tuple variant remote defs

    @dtolnay
    dtolnay committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    6502b31 View commit details
    Browse the repository at this point in the history

  3. Revert "Add FIXME to fix dead_code warning when using serde(remote)"

    @dtolnay
    dtolnay committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    38d9e0b View commit details
    Browse the repository at this point in the history