Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide opt-out feature=from_source to use serde_derive source #2580

Closed
wants to merge 10 commits into from
Closed

Provide opt-out feature=from_source to use serde_derive source #2580

wants to merge 10 commits into from
+27 −2

Commits on Aug 19, 2023

  1. Add derive_compiled feature to force full compilation of derive

    @sagudev
    sagudev committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    3cb80db View commit details
    Browse the repository at this point in the history

  2. Add cfg opt-in for the precompiled binary

    @pinkforest
    pinkforest committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    b12293e View commit details
    Browse the repository at this point in the history

  3. Remove redundant features

    @pinkforest
    pinkforest committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    8d54439 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Use opt-out instead and provide doc

    @pinkforest
    pinkforest committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    2e5bba0 View commit details
    Browse the repository at this point in the history

  2. Add simplified gating via build.rs

    @pinkforest
    pinkforest committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    10a0210 View commit details
    Browse the repository at this point in the history

  3. Provide the opt-out gate without build.rs

    @pinkforest
    pinkforest committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    81e79c1 View commit details
    Browse the repository at this point in the history

  4. Fix the manifest gate for opt-out - thanks @sagudev 

    Co-authored-by: sagudev <16504129+sagudev@users.noreply.github.com>
    @pinkforest @sagudev
    pinkforest and sagudev committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    6bccee7 View commit details
    Browse the repository at this point in the history

  5. Provide opt-out source compilation by feature `from_source 

    Co-authored-by: sagudev <16504129+sagudev@users.noreply.github.com>
Co-authored-by: Oliver Schneider <oli-obk@users.noreply.github.com>
    @pinkforest @sagudev @oli-obk
    3 people committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    5854820 View commit details
    Browse the repository at this point in the history

  6. Provide another opt-out alternative w/ nightly with cross-compile 

    With stable in non-cross compile context is still possible:

RUSTFLAGS='--cfg serde_derive_build="source"'

Co-authored-by: Nemo157 <github@nemo157.com>
    @pinkforest @Nemo157
    pinkforest and Nemo157 committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    23059f7 View commit details
    Browse the repository at this point in the history

  7. Switch back to opt-out feature=from_source override. 

    This can be useful in target environments which require building
from the source.

The feature flag is provided both via serde_derive and serde.

Co-authored-by: sagudev <16504129+sagudev@users.noreply.github.com>
Co-authored-by: Oliver Schneider <oli-obk@users.noreply.github.com>
    @pinkforest @sagudev @oli-obk
    3 people committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    cb23de9 View commit details
    Browse the repository at this point in the history