Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exhaustive internally tagged tests + support of internally tagged enums in non self-describing formats #2569

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
84d1c53
Use correct tokens in test to represent an enum variant
Mingun Aug 6, 2023
6a097ec
Add canary test to ensure that we use adequate enum representation
Mingun Aug 7, 2023
4437833
Convert test_internally_tagged_enum into module
Mingun Apr 22, 2023
6fadf4d
Move all internally tagged enum tests into a dedicated module
Mingun Jul 27, 2023
269be57
Remove excess test
Mingun Apr 22, 2023
55c0bfb
Give meaningful names to enum variants
Mingun Apr 22, 2023
b1af745
Reorder enum variants and tests to canonical order (Unit, Newtype, Tu…
Mingun Apr 22, 2023
23323b6
Move internally tagged enum tests into a dedicated file
Mingun Jul 27, 2023
310e00a
Move all other internally tagged enum tests into a dedicated file
Mingun Jul 27, 2023
4e12f39
Use the same order of derives
Mingun Aug 7, 2023
45512d6
Use name "tag" to refer to tag field
Mingun Aug 7, 2023
2be1112
Reuse type in unit_variant_with_unknown_fields and add test for sequence
Mingun Aug 7, 2023
541d76e
Reuse type in newtype_variant_containing_unit
Mingun Aug 7, 2023
b01f5bd
Rename unit struct to a generic name: Info->Unit
Mingun Aug 7, 2023
047e7a5
Share unit struct Unit between all tests
Mingun Aug 7, 2023
4770a7e
Reuse type in newtype_variant_containing_unit_struct
Mingun Aug 7, 2023
dfc8527
Rename externally tagged enum Inner to Enum
Mingun Aug 7, 2023
23f3e22
Share externally tagged enum Enum between all tests and reuse in stru…
Mingun Aug 7, 2023
5af0e8e
Reuse type in newtype_variant_containing_externally_tagged_enum
Mingun Aug 7, 2023
b2cca0d
Reuse type in struct_variant_containing_unit_variant
Mingun Aug 7, 2023
43ab6d6
Move and rename tests:
Mingun Aug 7, 2023
9b4cb8b
Convert newtype_enum and struct_enum tests into modules
Mingun Aug 7, 2023
437cf03
Add tests with borrowed strings
Mingun Aug 7, 2023
5a18a4d
Add tests for special and general cases for internally tagged enums
Mingun Oct 3, 2022
de4c2de
Add missing tests for enum variants as a values of struct variant of …
Mingun Aug 7, 2023
426b3a5
Temporary solve https://github.com/serde-rs/test/pull/31 by using patch
Mingun Aug 12, 2023
f869500
Add test for sequence in newtype_variant_containing_unit
Mingun Aug 7, 2023
b4e73e2
Unify handling of unit and unit structs in ContentDeserializer
Mingun Aug 7, 2023
b9a4860
Add additional checks for unit and newtype_unit tests
Mingun Aug 7, 2023
1006028
Deserializer should not check correctness of data, this is the respon…
Mingun Aug 12, 2023
dafede9
Add support for internally tagged enums in non self-describing formats
Mingun Aug 12, 2023
a08c600
Add support for struct variants in untagged and adjacently tagged enu…
Mingun Aug 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ members = [

[patch.crates-io]
serde = { path = "serde" }
# Temorary until https://github.com/serde-rs/test/pull/31 is merged
serde_test = { git = "https://github.com/Mingun/serde-test", branch = "borrowed-variant-identifiers" }