Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2018 edition #2546

Merged
merged 4 commits into from Jul 31, 2023
Merged

Update to 2018 edition #2546

merged 4 commits into from Jul 31, 2023

Commits on Jul 31, 2023

  1. Delete support for compilers without crate::-based module system

    @dtolnay
    dtolnay committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3eec111 View commit details
    Browse the repository at this point in the history

  2. Apply 'cargo fix --edition'

    @dtolnay
    dtolnay committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    ab90fbc View commit details
    Browse the repository at this point in the history

  3. Update to 2018 edition

    @dtolnay
    dtolnay committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    830528d View commit details
    Browse the repository at this point in the history

  4. Resolve ambiguous core import on rustc 1.64 through 1.71 

    In 1.72+, this is fixed by rust-lang/rust#112086.

    error[E0659]: `core` is ambiguous
       --> serde/src/lib.rs:227:13
        |
    227 |     pub use core::ffi::CStr;
        |             ^^^^ ambiguous name
        |
        = note: ambiguous because of multiple potential import sources
        = note: `core` could refer to a built-in crate
        = help: use `::core` to refer to this crate unambiguously
    note: `core` could also refer to the module defined here
       --> serde/src/lib.rs:166:5
        |
    166 | /     mod core {
    167 | |         #[cfg(not(feature = "std"))]
    168 | |         pub use core::*;
    169 | |         #[cfg(feature = "std")]
    170 | |         pub use std::*;
    171 | |     }
        | |_____^
        = help: use `self::core` to refer to this module unambiguously
    @dtolnay
    dtolnay committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0d7349f View commit details
    Browse the repository at this point in the history