Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep aliases always sorted and include aliases in expecting message for field/variant_identifier #2458

Merged
merged 9 commits into from
Aug 5, 2023
Merged

Keep aliases always sorted and include aliases in expecting message for field/variant_identifier #2458

merged 9 commits into from
Aug 5, 2023

Commits on Jul 23, 2023

  1. Keep aliases sorted

    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    bb51e68 View commit details
    Browse the repository at this point in the history

  2. Group field_identifier and variant_identifier tests in sub-modules 

    (review this commit with "ignore whitespace changes" option on)
    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    967023b View commit details
    Browse the repository at this point in the history

  3. Add tests for unknown field / variant

    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    bc1960b View commit details
    Browse the repository at this point in the history

  4. Add tests for aliases 

    failures (2):
    field_identifier::unknown
    variant_identifier::unknown
    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    1efb8b6 View commit details
    Browse the repository at this point in the history

  5. Show possible aliases in the expected message 

    Fixes tests
    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    78fea3a View commit details
    Browse the repository at this point in the history

  6. Slightly reduced number of allocations

    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    7ca7720 View commit details
    Browse the repository at this point in the history

  7. Eliminate additional allocations for flattening aliases

    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    855acaf View commit details
    Browse the repository at this point in the history

  8. Eliminate even more allocations

    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    089aae1 View commit details
    Browse the repository at this point in the history

  9. Do not run the code when results are not used

    @Mingun
    Mingun committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    f709fc0 View commit details
    Browse the repository at this point in the history