Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update webpack to 5.88.1 #675

Merged
merged 1 commit into from Jul 6, 2023
Merged

fix: Update webpack to 5.88.1 #675

merged 1 commit into from Jul 6, 2023

Conversation

sravan-s
Copy link
Contributor

@sravan-s sravan-s commented Jul 6, 2023

To make Cross-realm object access in Webpack 5 go away
See: https://nvd.nist.gov/vuln/detail/CVE-2023-28154

Webpack is somewhere down below in dependency list,
so just update package-lock ~

Bonus: Remove APP_ID from consts

Fixes: https://sendbird.atlassian.net/browse/CLNP-308

@AhyoungRyu
Copy link
Contributor

Wouldn't it be override the changed package-lock if we run npm install under the TS sample directory?

@sravan-s
Copy link
Contributor Author

sravan-s commented Jul 6, 2023

Hmmm, if you install something new, or use old version of npm, yeah.. Otherwise no.. But, we really dont need to worry about this.

We can even just delete that file

This is to make this guy silent
Screen Shot 2023-07-06 at 10 48 25 AM

Copy link
Contributor

@AhyoungRyu AhyoungRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good as a workaround

@sravan-s sravan-s merged commit 70360f6 into main Jul 6, 2023
1 check passed
@sravan-s sravan-s deleted the fix/CLNP-308/WEBPACK branch July 6, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants